Update Camera::hdr docs #8634
Merged
Update Camera::hdr docs #8634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
added
C-Docs
Merged
tim-blackbird
approved these changes
May 19, 2023
There was a problem hiding this comment.
@cart, Does HDR + MSAA working on WebGL open the door for enabling HDR by default?
james7132
approved these changes
May 19, 2023
It most certainly does! We should try the switch and see if anything breaks. If we survive a whole release with it on by default / nobody breaking, I think we should consider making hdr the only path |
cart
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates/removes an outdated doc comment. It seems to work without issue now.
We could also consider making hdr the default at this point.
Changelog
Camera::hdrnow works on WebGL2.