Add system parameter for computing up-to-date GlobalTransforms
#8603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
requested changes
May 14, 2023
james7132
added
C-Feature
|
This could be very useful for implementing inverse kinematics for animation systems. Added the |
james7132
approved these changes
Jul 5, 2023
hymm
reviewed
Aug 10, 2023
| /// you use the [`GlobalTransform`] component stored on the entity, unless you need | ||
| /// a [`GlobalTransform`] that reflects the changes made to any [`Transform`]s since | ||
| /// the last time the transform propagation systems ran. | ||
| #[derive(SystemParam)] |
There was a problem hiding this comment.
Should probably mention that this takes read access on Parent and Transform
hymm
approved these changes
Oct 4, 2023
| } | ||
| } | ||
|
|
||
| fn map_error(err: QueryEntityError, ancestor: bool) -> ComputeGlobalTransformError { |
There was a problem hiding this comment.
should we use a const generic for ancestor?
hymm
added
the
S-Ready-For-Final-Review
killercup
reviewed
Oct 9, 2023
| } | ||
|
|
||
| /// Error returned by [`TransformHelper::compute_global_transform`]. | ||
| #[derive(Debug)] |
There was a problem hiding this comment.
Not sure how important but would be nice to derive Error on all error things :)
|
@devil-ira CI failures look real: could you fix it up? |
alice-i-cecile
added
the
S-Adopt-Me
NoahShomette
suggested changes
Oct 18, 2023
Co-authored-by: Noah <noahshomette@gmail.com>
alice-i-cecile
removed
the
S-Adopt-Me
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
…yengine#8603) # Objective Add a way to easily compute the up-to-date `GlobalTransform` of an entity. ## Solution Add the `TransformHelper`(Name pending) system parameter with the `compute_global_transform` method that takes an `Entity` and returns a `GlobalTransform` if successful. ## Changelog - Added the `TransformHelper` system parameter for computing the up-to-date `GlobalTransform` of an entity. --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Noah <noahshomette@gmail.com>
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…yengine#8603) # Objective Add a way to easily compute the up-to-date `GlobalTransform` of an entity. ## Solution Add the `TransformHelper`(Name pending) system parameter with the `compute_global_transform` method that takes an `Entity` and returns a `GlobalTransform` if successful. ## Changelog - Added the `TransformHelper` system parameter for computing the up-to-date `GlobalTransform` of an entity. --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Noah <noahshomette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add a way to easily compute the up-to-date
GlobalTransformof an entity.Solution
Add the
TransformHelper(Name pending) system parameter with thecompute_global_transformmethod that takes anEntityand returns aGlobalTransformif successful.Changelog
TransformHelpersystem parameter for computing the up-to-dateGlobalTransformof an entity.