Support to set window theme and expose system window theme changed event #8593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you add something in example https://github.com/bevyengine/bevy/blob/main/examples/window/window_settings.rs showing how to change the theme on a key press? |
mockersf
added
the
A-Windowing
|
Took a shot at adding the above to the example here: lewiszlw#1 |
Toggle the window's theme in the example
|
Thanks @hate to update example! |
mnmaita
reviewed
May 17, 2023
nicopap
suggested changes
May 21, 2023
crates/bevy_window/src/window.rs
Outdated
| /// | ||
| /// ## Platform-specific | ||
| /// | ||
| /// - iOS / Android / Web / x11: Unsupported. |
There was a problem hiding this comment.
Suggested change
| /// - iOS / Android / Web / x11: Unsupported. | |
| /// Unsupported on iOS, Android, Web and X11. The return value is always the last set value or `None` on those platforms. |
There was a problem hiding this comment.
There is a bit of an issue here.
On unsupported platforms, winit always returns None when using window.theme(). However, in this bevy implementation, it's possible to set self.internal.window_theme to Some(Theme) in set_window_theme. Now this will return a misleading value.
I suggest conditionally returning None here, something like
if cfg!(any(target_os = "ios", target_os = "android", target_family = "wasm", feature = "x11")) {
None
} else {
self.internal.window_theme
}
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
nicopap
suggested changes
May 29, 2023
Revert From trait implementation
nicopap
approved these changes
May 30, 2023
nicopap
added
C-Enhancement
mockersf
reviewed
May 30, 2023
Co-authored-by: François <mockersf@gmail.com>
alice-i-cecile
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
preferred_themefield toWindowand set it when window creationwindow_themefield toInternalWindowStateto store current window themeWindowThemeChangedevent