-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take example screenshots in CI #8488
Conversation
Example |
Example |
Example |
Example |
Example screenshots can be found in the artefacts section of https://github.com/bevyengine/bevy/actions/runs/4800302635 |
Would be awesome to use these CI-generated images in the examples page of the website :) |
That will be the plan after the next release (if this gets merged)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this idea in theory, and the API is good. I'm curious to see how this ends up being used and how new screenshots can be blessed, but I'm content with this as a first step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's definitely more work to be done, but this seems like a very good first step to me.
Objective
Solution
I reused the
TimeUpdateStrategy::ManualDuration
to be able to set the time update strategy to a fixed duration every frame. Its previous meaning didn't make much sense to me. This change makes it possible to have screenshots that are exactly the same across runs.If this gets merged, I'll add visual comparison of screenshots between runs to ensure nothing gets broken
Migration Guide
TimeUpdateStrategy::ManualDuration
meaning has changed. Instead of setting time toInstant::now()
plus the given duration, it sets time to last update plus the given duration.