Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect Component and Default of BloomSettings #8283

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Reflect Component and Default of BloomSettings #8283

merged 1 commit into from
Apr 1, 2023

Conversation

SludgePhD
Copy link
Contributor

These traits are both implemented, but not reflected, requiring user code to do app.register_type_data::<BloomSettings, ReflectDefault>().register_type_data::<BloomSettings, ReflectComponent>() to make these usable via reflection.

@james7132 james7132 added this pull request to the merge queue Apr 1, 2023
@james7132 james7132 added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Apr 1, 2023
@james7132 james7132 added this to the 0.11 milestone Apr 1, 2023
Merged via the queue into bevyengine:main with commit d193d7f Apr 1, 2023
@SludgePhD SludgePhD deleted the bloomsetting-reflection branch April 1, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@jakobhellermann jakobhellermann jakobhellermann approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@SludgePhD @james7132 @jakobhellermann