Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruzstd requirement from 0.2.4 to 0.3.1 #8133

Closed
wants to merge 1 commit into from
Closed

Update ruzstd requirement from 0.2.4 to 0.3.1 #8133

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 20, 2023 •
edited
Loading

Updates the requirements on ruzstd to permit the latest version.

Release notes

Sourced from ruzstd's releases.

Support skippable frames and improve zstd binary

This support features support for

  • Skippable frames, which where previously regarded as a generally malformed frame
  • Decoding multiple frames in one file with the provided zstd binary (thanks @​phord)
Commits
  • a4d5d48 bump version number
  • d7351b4 mention zstd binary in the readme
  • b8c447e better wording
  • 39bda0d cleanup the readme from a lot of unnecessary info
  • 56f481d keep optimization document up to date
  • 993d0a7 make error format for skippable frames nicer
  • 6b5e4e8 Merge pull request #37 from KillingSpark/skipable_frames
  • 4aef98d add basic support for skippable frames
  • 6174749 Merge pull request #36 from phord/master
  • dc3ef95 zstd: Use range slices instead of resizing vectors
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot
Update ruzstd requirement from 0.2.4 to 0.3.1
ed700f2 
Updates the requirements on [ruzstd](https://github.com/KillingSpark/zstd-rs) to permit the latest version.
- [Release notes](https://github.com/KillingSpark/zstd-rs/releases)
- [Commits](KillingSpark/zstd-rs@v0.2.4...v0.3.1)

---
updated-dependencies:
- dependency-name: ruzstd
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the C-Dependencies A change to the crates that Bevy depends on label Mar 20, 2023
@james7132 james7132 added the S-Blocked This cannot move forward until something else changes label Mar 20, 2023
@james7132
Copy link
Member

This is blocked on all of our other dependencies updating to syn 2.0. Or adding explicit exceptions for the ones that haven't. Though given how extensive and heavy compiling one version of syn is, it may be worth waiting for all of our dependencies to update first.

@cart
Copy link
Member

cart commented Mar 21, 2023

I think we'll start hitting the "dupe dep" stuff anyway as serde just updated to syn 2.0 on a patch release. Imo we should just make an exception and try to get everything migrated asap.

@mockersf mockersf mentioned this pull request May 16, 2023
Merged
@mockersf
Copy link
Member

closed in favour of #8622

@mockersf mockersf closed this May 16, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 16, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/ruzstd-0.3.1 branch May 16, 2023 22:06
mockersf added a commit that referenced this pull request May 17, 2023
@mockersf
Update ruzstd and basis universal (#8622)
ad88759 
# Objective

- Update dependencies `ruzstd` and `basis-universal`
- Alternative to #5278 and #8133

## Solution

- Update the dependencies, fix the code
- Bevy now also depend on `syn@2` so it's not a blocker to update
`ruzstd` anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-Dependencies A change to the crates that Bevy depends on S-Blocked This cannot move forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james7132 @cart @mockersf