Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not set hit test unconditionally on window creation #7996

Merged
merged 1 commit into from
Mar 13, 2023
Merged

do not set hit test unconditionally on window creation #7996

merged 1 commit into from
Mar 13, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 9, 2023

Objective

Solution

  • Do not set the window hit test if it's the default value

@mockersf mockersf mentioned this pull request Mar 9, 2023
Merged
@james7132 james7132 added A-Windowing Platform-agnostic interface layer to run your app in O-Web Specific to web (WASM) builds O-Android Specific to the Android mobile operating system O-iOS Specific to the iOS mobile operating system C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Mar 9, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 13, 2023
Merged via the queue into bevyengine:main with commit 71b1b35 Mar 13, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@mockersf @Shfty
do not set hit test unconditionally on window creation (bevyengine#7996)
8b71208
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@mockersf @Shfty
do not set hit test unconditionally on window creation (bevyengine#7996)
553bf94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior O-Android Specific to the Android mobile operating system O-iOS Specific to the iOS mobile operating system O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @james7132 @tim-blackbird @alice-i-cecile