[Merged by Bors] - add standard material depth bias to pipeline #7847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
mxgrey
reviewed
Mar 1, 2023
| @@ -507,6 +508,7 @@ pub struct MaterialProperties { | |||
| pub alpha_mode: AlphaMode, | |||
| /// Add a bias to the view depth of the mesh which can be used to force a specific render order | |||
| /// for meshes with equal depth, to avoid z-fighting. | |||
There was a problem hiding this comment.
Suggested change
| /// for meshes with equal depth, to avoid z-fighting. | |
| /// for meshes with similar depth, to avoid z-fighting. |
nit: change this line to match the change in documentation for fn depth_bias(&self)
james7132
approved these changes
Mar 1, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2023
# Objective the current depth bias only adjusts ordering, so it doesn't work for opaque meshes vs alpha-blend meshes, and it doesn't help when two meshes are infinitesimally offset from one another. ## Solution pass the material's depth bias into the pipeline depth stencil `constant` field.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
# Objective the current depth bias only adjusts ordering, so it doesn't work for opaque meshes vs alpha-blend meshes, and it doesn't help when two meshes are infinitesimally offset from one another. ## Solution pass the material's depth bias into the pipeline depth stencil `constant` field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
the current depth bias only adjusts ordering, so it doesn't work for opaque meshes vs alpha-blend meshes, and it doesn't help when two meshes are infinitesimally offset from one another.
Solution
pass the material's depth bias into the pipeline depth stencil
constantfield.