Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix a typo in CombinatorSystem #7823

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix a typo in CombinatorSystem #7823

wants to merge 1 commit into from

Conversation

joseph-gio
Copy link
Member

Objective

I made a typo in #7605.

Solution

Fix it.

@joseph-gio joseph-gio added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Feb 26, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 26, 2023
alice-i-cecile
alice-i-cecile approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Feb 26, 2023
@joseph-gio
Fix a typo in CombinatorSystem (#7823)
15c55a1 
# Objective

I made a typo in #7605.

## Solution

Fix it.
@bors
Copy link
Contributor

bors bot commented Feb 26, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix a typo in CombinatorSystem [Merged by Bors] - Fix a typo in CombinatorSystem Feb 26, 2023
@bors bors bot closed this Feb 26, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@joseph-gio @Shfty
Fix a typo in CombinatorSystem (bevyengine#7823)
e687483 
# Objective

I made a typo in bevyengine#7605.

## Solution

Fix it.
@joseph-gio joseph-gio deleted the fix-typo branch September 20, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joseph-gio @alice-i-cecile @mockersf