Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove unnecessary scopes in App methods #7813

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove unnecessary scopes in App methods #7813

wants to merge 1 commit into from

Conversation

joseph-gio
Copy link
Member

Objective

A couple of places in bevy_app use a scoped block that doesn't do anything. I imagine these are a relic from when Mut<T> implemented Drop in the early days of bevy.

Solution

Remove the scopes.

@joseph-gio joseph-gio added C-Code-Quality A section of code that is hard to understand or change A-App Bevy apps and plugins labels Feb 25, 2023
james7132
james7132 approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Feb 25, 2023
@joseph-gio
Remove unnecessary scopes in App methods (#7813)
af4b95c 
# Objective

A couple of places in `bevy_app` use a scoped block that doesn't do anything. I imagine these are a relic from when `Mut<T>` implemented `Drop` in the early days of bevy.

## Solution

Remove the scopes.
@bors
Copy link
Contributor

bors bot commented Feb 25, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove unnecessary scopes in App methods [Merged by Bors] - Remove unnecessary scopes in App methods Feb 25, 2023
@bors bors bot closed this Feb 25, 2023
@joseph-gio joseph-gio deleted the remove-scopes branch February 25, 2023 21:47
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@joseph-gio @Shfty
Remove unnecessary scopes in App methods (bevyengine#7813)
5f41317 
# Objective

A couple of places in `bevy_app` use a scoped block that doesn't do anything. I imagine these are a relic from when `Mut<T>` implemented `Drop` in the early days of bevy.

## Solution

Remove the scopes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joseph-gio @james7132 @alice-i-cecile @mockersf