Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix regex for shader define: must have at least one whitespace #7754

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix regex for shader define: must have at least one whitespace #7754

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

  • Nothing render
ERROR bevy_render::render_resource::pipeline_cache: failed to process shader: Invalid shader def definition for '_import_path': bevy_pbr

Solution

  • Fix define regex so that it must have one whitespace after define

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-Critical This must be fixed immediately or contributors or users will be severely impacted labels Feb 20, 2023
superdump
superdump approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Feb 20, 2023
@mockersf
fix regex for shader define: must have at least one whitespace (#7754)
7ec9258 
# Objective

- Nothing render
```
ERROR bevy_render::render_resource::pipeline_cache: failed to process shader: Invalid shader def definition for '_import_path': bevy_pbr
```

## Solution

- Fix define regex so that it must have one whitespace after `define`
@bors
Copy link
Contributor

bors bot commented Feb 20, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title fix regex for shader define: must have at least one whitespace [Merged by Bors] - fix regex for shader define: must have at least one whitespace Feb 20, 2023
@bors bors bot closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Critical This must be fixed immediately or contributors or users will be severely impacted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @superdump