Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix last_changed() and set_last_changed() for MutUntyped #7619

Closed
wants to merge 3 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Feb 11, 2023

Objective

Continuation of #7560.

MutUntyped::last_changed and set_last_changed do not behave as described in their docs.

Solution

Fix them using the same approach that was used for Mut<> in #7560.

@JoJoJet JoJoJet added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Feb 11, 2023
@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Feb 11, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 11, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 11, 2023
# Objective

Continuation of #7560.

`MutUntyped::last_changed` and `set_last_changed` do not behave as described in their docs.

## Solution

Fix them using the same approach that was used for `Mut<>` in #7560.
@bors bors bot changed the title Fix last_changed() and set_last_changed() for MutUntyped [Merged by Bors] - Fix last_changed() and set_last_changed() for MutUntyped Feb 11, 2023
@bors bors bot closed this Feb 11, 2023
@JoJoJet JoJoJet deleted the finish-fix branch February 11, 2023 21:28
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 14, 2023
…ngine#7619)

# Objective

Continuation of bevyengine#7560.

`MutUntyped::last_changed` and `set_last_changed` do not behave as described in their docs.

## Solution

Fix them using the same approach that was used for `Mut<>` in bevyengine#7560.
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
…ngine#7619)

# Objective

Continuation of bevyengine#7560.

`MutUntyped::last_changed` and `set_last_changed` do not behave as described in their docs.

## Solution

Fix them using the same approach that was used for `Mut<>` in bevyengine#7560.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants