[Merged by Bors] - Optimise EventReader::clear() and improve documentation
#7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-blackbird
changed the title
EventReader::clear(). Improve documentation.EventReader::clear() and improve documentation
alice-i-cecile
approved these changes
Feb 2, 2023
alice-i-cecile
added
C-Docs
JoJoJet
approved these changes
Feb 2, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
# Objective Clearing the reader doesn't require iterating the events. Updating the `last_event_count` of the reader is enough. I rewrote part of the documentation as some of it was incorrect or harder to understand than necessary. ## Changelog Added `ManualEventReader::clear()` Co-authored-by: devil-ira <justthecooldude@gmail.com>
bors
bot
changed the title
EventReader::clear() and improve documentationEventReader::clear() and improve documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Clearing the reader doesn't require iterating the events. Updating the
last_event_countof the reader is enough.I rewrote part of the documentation as some of it was incorrect or harder to understand than necessary.
Changelog
Added
ManualEventReader::clear()