[Merged by Bors] - Fix ignored lifetimes in #[derive(SystemParam)]
#7458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
C-Bug
JoJoJet
changed the title
#[derive(SystemParam)]#[derive(SystemParam)]
alice-i-cecile
approved these changes
Feb 1, 2023
5 tasks
james7132
approved these changes
Feb 3, 2023
james7132
added
the
S-Ready-For-Final-Review
BoxyUwU
approved these changes
Feb 3, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
# Objective Fix #7447. The `SystemParam` derive uses the wrong lifetimes for ignored fields. ## Solution Use type inference instead of explicitly naming the types of ignored fields. This allows the compiler to automatically use the correct lifetime.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
#[derive(SystemParam)]#[derive(SystemParam)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #7447.
The
SystemParamderive uses the wrong lifetimes for ignored fields.Solution
Use type inference instead of explicitly naming the types of ignored fields. This allows the compiler to automatically use the correct lifetime.