Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Derive Copy for Aabb #7401

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Derive Copy for Aabb #7401

wants to merge 1 commit into from

Conversation

djeedai
Copy link
Contributor

@djeedai djeedai commented Jan 28, 2023

Objective

Derive Copy for Aabb

Solution

Just do it :)

Changelog

  • The Aabb type now derives Copy.

@djeedai djeedai added A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use A-Math Fundamental domain-agnostic mathematical operations labels Jan 28, 2023
@superdump
Copy link
Contributor

This will need rebasing when the FromReflect PR is merged.

superdump
superdump approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Jan 30, 2023
@djeedai
Derive Copy for Aabb (#7401)
1dd3fe0 
# Objective

Derive `Copy` for `Aabb`

## Solution

Just do it :)

---

## Changelog

- The `Aabb` type now derives `Copy`.
@bors
Copy link
Contributor

bors bot commented Jan 30, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Derive Copy for Aabb [Merged by Bors] - Derive Copy for Aabb Jan 30, 2023
@bors bors bot closed this Jan 30, 2023
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@djeedai @ItsDoot
Derive Copy for Aabb (bevyengine#7401)
cf2e229 
# Objective

Derive `Copy` for `Aabb`

## Solution

Just do it :)

---

## Changelog

- The `Aabb` type now derives `Copy`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@VitalyAnkh VitalyAnkh VitalyAnkh approved these changes

@nicopap nicopap nicopap approved these changes

@kurtkuehnert kurtkuehnert kurtkuehnert approved these changes

@torsteingrindvik torsteingrindvik torsteingrindvik approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@djeedai @superdump @VitalyAnkh @nicopap @kurtkuehnert @torsteingrindvik