Cursor lock crash fix #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also hit this bug on wasm. I fixed it in #703 and i think the fix there is slightly safer because it only ignores "unsupported platform" failures, while still hard-failing when a real platform failure is hit. I'm closing this, but feel free to continue the conversation if you have other thoughts. |
|
Yeah, I like your fix more. But it seems like it could still crash at |
karroffel
added
C-Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case cursor locking isn't supported by platform (like iOS) winit's
window.set_cursor_grabwould returnErr. Unwrapping it results in panic.This should fix #697