[Merged by Bors] - Removed Mobile Touch event y-axis flip #6597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
|
Can you remove it for iOS too? Even without testing this is virtually guaranteed to not be needed anymore. |
alice-i-cecile
added
the
A-Input
|
Removed it for ios |
alice-i-cecile
approved these changes
Nov 14, 2022
james7132
added
O-Android
mockersf
approved these changes
Nov 17, 2022
|
tested on iOS 👍 |
mockersf
added
the
S-Ready-For-Final-Review
|
Could you change the PR title to reflect it's also for iOS? The title will be used as the commit name in git history |
|
I'll merge this once the title is updated. |
slyedoc
changed the title
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
# Objective Fix android touch events being flipped. Only removed test for android, don't have ios device to test with. Tested with emulator and physical device. ## Solution Remove check, no longer needed with coordinate change in 0.9
bors
bot
changed the title
cart
pushed a commit
that referenced
this pull request
Nov 30, 2022
# Objective Fix android touch events being flipped. Only removed test for android, don't have ios device to test with. Tested with emulator and physical device. ## Solution Remove check, no longer needed with coordinate change in 0.9
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fix android touch events being flipped. Only removed test for android, don't have ios device to test with. Tested with emulator and physical device. ## Solution Remove check, no longer needed with coordinate change in 0.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix android touch events being flipped. Only removed test for android, don't have ios device to test with. Tested with emulator and physical device.
Solution
Remove check, no longer needed with coordinate change in 0.9