Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Bump gilrs version to 0.10 #6558

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Bump gilrs version to 0.10 #6558

wants to merge 2 commits into from

Conversation

james7132
Copy link
Member

Objective

Fix #6555.

Solution

Bump gilrs version to 0.10.

@james7132 james7132 added A-Input Player input via keyboard, mouse, gamepad, and more C-Dependencies A change to the crates that Bevy depends on C-Bug An unexpected or incorrect behavior labels Nov 12, 2022
alice-i-cecile
alice-i-cecile approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate dependencies are annoying, but I have a hard time arguing they're more important than supporting major controllers.

@mockersf mockersf added the S-Blocked This cannot move forward until something else changes label Nov 12, 2022
@mockersf
Copy link
Member

mockersf commented Nov 12, 2022 •
edited
Loading

gilrs 0.10 is breaking support for controllers on macOS. it has been fixed but not yet released

@paul-hansen
Copy link
Contributor

Duplicate dependencies are annoying, but I have a hard time arguing they're more important than supporting major controllers.

Opened a PR with Cpal to update their windows crate RustAudio/cpal#726, I think that should solve the duplicate dependency. Will take a while to get downstream to us and I agree that it would be worth merging before then. (Once gilrs has the macOS fix out.)

@paul-hansen
Copy link
Contributor

Gilrs 0.10.1 just dropped! Should have the MacOS fix.
https://crates.io/crates/gilrs/0.10.1
Also includes my fix to make wasm binary smaller and a fix for north and west buttons being flipped on Wasm too.

@alice-i-cecile alice-i-cecile removed the S-Blocked This cannot move forward until something else changes label Nov 13, 2022
@james7132
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Nov 13, 2022
@bors
Try #6558:
ed4ebdb
@mockersf
Copy link
Member

could you update to 0.10.1 to ensure the 0.10.0 won't be used?

@bors
Copy link
Contributor

bors bot commented Nov 13, 2022

try

Build succeeded:

@mockersf mockersf added this to the 0.9.1 milestone Nov 13, 2022
@mockersf mockersf mentioned this pull request Nov 13, 2022
Closed
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 14, 2022
@cart
Copy link
Member

cart commented Nov 15, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 15, 2022
@james7132
Bump gilrs version to 0.10 (#6558)
51aab03 
# Objective
Fix #6555.

## Solution
Bump `gilrs` version to 0.10.
@bors
Copy link
Contributor

bors bot commented Nov 15, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Bump gilrs version to 0.10 [Merged by Bors] - Bump gilrs version to 0.10 Nov 15, 2022
@bors bors bot closed this Nov 15, 2022
@james7132 james7132 deleted the gilrs-0.10 branch November 18, 2022 04:18
cart pushed a commit that referenced this pull request Nov 30, 2022
@james7132 @cart
Bump gilrs version to 0.10 (#6558)
e30019b 
# Objective
Fix #6555.

## Solution
Bump `gilrs` version to 0.10.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@james7132 @ItsDoot
Bump gilrs version to 0.10 (bevyengine#6558)
ff80016 
# Objective
Fix bevyengine#6555.

## Solution
Bump `gilrs` version to 0.10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Bug An unexpected or incorrect behavior C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

Gamepad input not working for DualSense (PS5) controller
5 participants
@james7132 @mockersf @paul-hansen @cart @alice-i-cecile