[Merged by Bors] - Add globals struct to mesh2d #6222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When using `Material2d` for shaders, allow accessing the `globals` struct. This work is based on commit 8073362, whichs adds the struct to the 3D counterpart. - Copy the struct from `bevy_pbr` as-is into `bevy_sprite`. Update the bind group layout and the bind group creation to match. - Binds the `globals` struct as a uniform in group 0 binding 1 for the mesh 2D view. Signed-off-by: Torstein Grindvik <torstein.grindvik@nordicsemi.no>
|
Yep, that was an omission on my part. I think just copying it is fine for now. I'll have a look at this in a few hours. |
IceSentry
added
A-Rendering
|
Note: I searched for uses of |
alice-i-cecile
approved these changes
Oct 10, 2022
IceSentry
approved these changes
Oct 10, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
See commit message. I noticed I couldn't use `globals.time` when using `Material2d`. I copied the solution from 8073362 , and now `Material2d` works for me. Perhaps some of these struct definitions could be shared in the future, but for now I've just copy pasted it (it looked like the `View` struct was done that way). Ping @IceSentry , I saw a comment on the linked commit that you intended to do this work at some point in the future.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
See commit message. I noticed I couldn't use `globals.time` when using `Material2d`. I copied the solution from 8073362 , and now `Material2d` works for me. Perhaps some of these struct definitions could be shared in the future, but for now I've just copy pasted it (it looked like the `View` struct was done that way). Ping @IceSentry , I saw a comment on the linked commit that you intended to do this work at some point in the future.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
See commit message. I noticed I couldn't use `globals.time` when using `Material2d`. I copied the solution from 8073362 , and now `Material2d` works for me. Perhaps some of these struct definitions could be shared in the future, but for now I've just copy pasted it (it looked like the `View` struct was done that way). Ping @IceSentry , I saw a comment on the linked commit that you intended to do this work at some point in the future.
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
See commit message. I noticed I couldn't use `globals.time` when using `Material2d`. I copied the solution from 8073362 , and now `Material2d` works for me. Perhaps some of these struct definitions could be shared in the future, but for now I've just copy pasted it (it looked like the `View` struct was done that way). Ping @IceSentry , I saw a comment on the linked commit that you intended to do this work at some point in the future.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
See commit message. I noticed I couldn't use `globals.time` when using `Material2d`. I copied the solution from 8073362 , and now `Material2d` works for me. Perhaps some of these struct definitions could be shared in the future, but for now I've just copy pasted it (it looked like the `View` struct was done that way). Ping @IceSentry , I saw a comment on the linked commit that you intended to do this work at some point in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
I noticed I couldn't use
globals.timewhen usingMaterial2d.I copied the solution from 8073362 , and now
Material2dworks for me.Perhaps some of these struct definitions could be shared in the future, but for now I've just copy pasted it (it looked like the
Viewstruct was done that way).Ping @IceSentry , I saw a comment on the linked commit that you intended to do this work at some point in the future.