Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sprite_sheet example - use ImageSettings #5642

Closed
wants to merge 1 commit into from
Closed

fix sprite_sheet example - use ImageSettings #5642

wants to merge 1 commit into from

Conversation

7flash
Copy link

@7flash 7flash commented Aug 10, 2022

Objective

fix the error

image

Solution

Works once ImageSettings imported

image

This was referenced Aug 10, 2022
Closed
Closed
@DJMcNab
Copy link
Member

DJMcNab commented Aug 10, 2022

I'm fairly sure this is a 0.8 vs main misunderstanding, and the user has ignored the warning to check their versions. This warning can be found https://github.com/bevyengine/bevy/tree/main/examples#examples

I believe this struct has since been added to the prelude.
This makes this change unidiomatic

@afonsolage
Copy link
Contributor

image
v0.8.0

image
main

Both on Windows 11 and it's working fine.

@Weibye Weibye added the S-User-Error This issue was caused by a mistake in the user's approach label Aug 10, 2022
@Weibye
Copy link
Contributor

Weibye commented Aug 10, 2022

@7flash Thanks for the work, the issue is already solved by #5566

Closing this

@Weibye Weibye closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-User-Error This issue was caused by a mistake in the user's approach
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@7flash @DJMcNab @afonsolage @Weibye