[Merged by Bors] - Enable loading textures of unlimited size #5305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nilirad
added
C-Bug
superdump
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
The limits are removed but if we run out of ram then we will still receive an error back from the decide function so this seems fine.
One thing to note is that if vram is filled, allocations will overflow to system ram, but I would guess that if both vram and system ram are full when trying to upload the texture to the gpu, then buffer creation would fail and I would hope we’re handling that regardless of this change.
mockersf
approved these changes
Jul 13, 2022
mockersf
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
# Objective Fixes #5304 ## Solution Instead of using a simple utility function for loading, which uses a default allocation limit of 512MB, we use a Reader object which can be configured ad hoc. ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. - Allows loading of textures larger than 512MB
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective Fixes bevyengine#5304 ## Solution Instead of using a simple utility function for loading, which uses a default allocation limit of 512MB, we use a Reader object which can be configured ad hoc. ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. - Allows loading of textures larger than 512MB
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Fixes bevyengine#5304 ## Solution Instead of using a simple utility function for loading, which uses a default allocation limit of 512MB, we use a Reader object which can be configured ad hoc. ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. - Allows loading of textures larger than 512MB
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#5304 ## Solution Instead of using a simple utility function for loading, which uses a default allocation limit of 512MB, we use a Reader object which can be configured ad hoc. ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. - Allows loading of textures larger than 512MB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #5304
Solution
Instead of using a simple utility function for loading, which uses a default allocation limit of 512MB, we use a Reader object which can be configured ad hoc.
Changelog