Create winit canvas under WebAssembly #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moxinilian
added
C-Enhancement
porkbrain
reviewed
Sep 18, 2020
memoryruins
suggested changes
Sep 18, 2020
|
Fantastic work as always! I think this is good to go as soon as the readme and index.html gets updated. Its probably not a problem yet, but as we start adding more bevy feature support, we might want to add a |
|
I guess current version should do it. > cargo build --example winit_wasm --target wasm32-unknown-unknown --no-default-features
error: target `winit_wasm` in package `bevy` requires the features: `bevy_winit`
Consider enabling them by passing, e.g., `--features="bevy_winit"` |
|
Sweetness. Lets merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change
wasm32build will actually create "window" canvas in browser and process input events on it.