[Merged by Bors] - bevy_ptr works in no_std environments #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
|
Still missing a A-Pointer label :( |
alice-i-cecile
approved these changes
May 15, 2022
TimJentzsch
approved these changes
May 15, 2022
mockersf
approved these changes
May 15, 2022
mockersf
added
the
S-Ready-For-Final-Review
bjorn3
approved these changes
May 15, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 16, 2022
# Objective `bevy_ptr` works just fine without `std`. Mark it as `no_std`. This should generally be useful for non-bevy use cases, but it also marginally speeds up compilation by allowing the crate to compile without loading the std-lib. ## Solution Replace `std` with `core`. Added `#![no_std]` to the crate and to the crate's tags. Also added a missing `#![warn(missing_docs)]` that the other crates have.
bors
bot
changed the title
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 17, 2022
# Objective `bevy_ptr` works just fine without `std`. Mark it as `no_std`. This should generally be useful for non-bevy use cases, but it also marginally speeds up compilation by allowing the crate to compile without loading the std-lib. ## Solution Replace `std` with `core`. Added `#![no_std]` to the crate and to the crate's tags. Also added a missing `#![warn(missing_docs)]` that the other crates have.
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective `bevy_ptr` works just fine without `std`. Mark it as `no_std`. This should generally be useful for non-bevy use cases, but it also marginally speeds up compilation by allowing the crate to compile without loading the std-lib. ## Solution Replace `std` with `core`. Added `#![no_std]` to the crate and to the crate's tags. Also added a missing `#![warn(missing_docs)]` that the other crates have.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective `bevy_ptr` works just fine without `std`. Mark it as `no_std`. This should generally be useful for non-bevy use cases, but it also marginally speeds up compilation by allowing the crate to compile without loading the std-lib. ## Solution Replace `std` with `core`. Added `#![no_std]` to the crate and to the crate's tags. Also added a missing `#![warn(missing_docs)]` that the other crates have.
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_ptrworks just fine withoutstd. Mark it asno_std. This should generally be useful for non-bevy use cases, but it also marginally speeds up compilation by allowing the crate to compile without loading the std-lib.Solution
Replace
stdwithcore. Added#![no_std]to the crate and to the crate's tags.Also added a missing
#![warn(missing_docs)]that the other crates have.