[Merged by Bors] - Add IntoIterator impls for &Query and &mut Query #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
requested changes
May 7, 2022
tim-blackbird
approved these changes
May 7, 2022
BoxyUwU
reviewed
May 7, 2022
|
|
||
| impl<'w, Q: WorldQuery, F: WorldQuery> IntoIterator for &'w mut Query<'_, '_, Q, F> { | ||
| type Item = QueryItem<'w, Q>; | ||
| type IntoIter = QueryIter<'w, 'w, Q, QueryFetch<'w, Q>, F>; |
There was a problem hiding this comment.
why is this not QueryIter<'w, 's, ...
There was a problem hiding this comment.
I copied the bounds off of iter_mut, since iter_mut bound both 'w and 's to the borrow lifetime i did the same for this impl.
Guvante
approved these changes
May 7, 2022
alice-i-cecile
added
A-ECS
BoxyUwU
approved these changes
May 7, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
May 8, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 9, 2022
# Objective These types of IntoIterator impls are a common pattern in Rust, and these implementations make this common pattern work for bevy queries.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
May 9, 2022
# Objective These types of IntoIterator impls are a common pattern in Rust, and these implementations make this common pattern work for bevy queries.
bors
bot
changed the title
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 10, 2022
# Objective These types of IntoIterator impls are a common pattern in Rust, and these implementations make this common pattern work for bevy queries.
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective These types of IntoIterator impls are a common pattern in Rust, and these implementations make this common pattern work for bevy queries.
3 tasks
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective These types of IntoIterator impls are a common pattern in Rust, and these implementations make this common pattern work for bevy queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
These types of IntoIterator impls are a common pattern in Rust, and these implementations make this common pattern work for bevy queries.