Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add get_multiple and get_multiple_mut APIs for Query and QueryState #4298

Closed
wants to merge 32 commits into from
Closed

[Merged by Bors] - Add get_multiple and get_multiple_mut APIs for Query and QueryState #4298

wants to merge 32 commits into from

Commits on Mar 22, 2022

  1. Basic function signatures

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    a78a231 View commit details
    Browse the repository at this point in the history

  2. Add AliasedMutability variant to QueryEntityError

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    2a22d98 View commit details
    Browse the repository at this point in the history

  3. QueryState methods

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    f822094 View commit details
    Browse the repository at this point in the history

  4. Query methods

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    f47b7ea View commit details
    Browse the repository at this point in the history

  5. Infallible variants

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    854bb1e View commit details
    Browse the repository at this point in the history

  6. Fix safety comment

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    712abda View commit details
    Browse the repository at this point in the history

  7. Make QueryEntityError more useful

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    34e92c7 View commit details
    Browse the repository at this point in the history

  8. Basic docs

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    063e616 View commit details
    Browse the repository at this point in the history

  9. Basic doc tests

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    2423515 View commit details
    Browse the repository at this point in the history

  10. Doc tests for unhappy paths

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    f04c390 View commit details
    Browse the repository at this point in the history

  11. Fix lifetimes on self 

    Co-authored-by: Boxy <supbscripter@gmail.com>
    @alice-i-cecile @BoxyUwU
    alice-i-cecile and BoxyUwU committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    3bc9432 View commit details
    Browse the repository at this point in the history

  12. Use unwrap_err to fix broken doc test

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    fce42c7 View commit details
    Browse the repository at this point in the history

  13. Deduplicate logic

    @alice-i-cecile
    alice-i-cecile committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    1932ee7 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Split logic into mutable and non-mutable variants to reduce unsafety

    @alice-i-cecile
    alice-i-cecile committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    1544dbb View commit details
    Browse the repository at this point in the history

  2. Use read-write Fetch type for get_multiple_unchecked_manual

    @alice-i-cecile
    alice-i-cecile committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    0f0d8ae View commit details
    Browse the repository at this point in the history

  3. Add compile-fail tests to verify lifetimes

    @alice-i-cecile
    alice-i-cecile committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    f5bb379 View commit details
    Browse the repository at this point in the history

  4. Fail to compile correctly

    @alice-i-cecile
    alice-i-cecile committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    913178b View commit details
    Browse the repository at this point in the history

  5. Blessed be the compiler error message

    @alice-i-cecile
    alice-i-cecile committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    b2e3786 View commit details
    Browse the repository at this point in the history

  6. Leave TODO 

    Co-authored-by: Yilin Wei <yilin.wei10@gmail.com>
    @alice-i-cecile @yilinwei
    alice-i-cecile and yilinwei committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    7d1b592 View commit details
    Browse the repository at this point in the history

  7. Compile fail test for get_multiple

    @alice-i-cecile
    alice-i-cecile committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    a266f5a View commit details
    Browse the repository at this point in the history

  8. Dedicated aliased mutability test

    @alice-i-cecile
    alice-i-cecile committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    f41213d View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Verify that we're working on the right World

    @alice-i-cecile
    alice-i-cecile committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    606c36e View commit details
    Browse the repository at this point in the history

  2. Remove from_raw from doc tests

    @alice-i-cecile
    alice-i-cecile committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    2edcb87 View commit details
    Browse the repository at this point in the history

  3. More robust error handling

    @alice-i-cecile
    alice-i-cecile committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    d2ad4fb View commit details
    Browse the repository at this point in the history

  4. Explicitly test for invalid entities

    @alice-i-cecile
    alice-i-cecile committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    5871b10 View commit details
    Browse the repository at this point in the history

  5. Also return the Entity for QueryEntityError::QueryDoesNotMatch

    @alice-i-cecile
    alice-i-cecile committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    1cd2963 View commit details
    Browse the repository at this point in the history

  6. Fix tests

    @alice-i-cecile
    alice-i-cecile committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    22337a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Move world validation into QueryState::get_mulitple_mut

    @alice-i-cecile
    alice-i-cecile committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    86f1521 View commit details
    Browse the repository at this point in the history

  2. World is already validated by update_archetypes call

    @alice-i-cecile
    alice-i-cecile committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    be22235 View commit details
    Browse the repository at this point in the history

  3. Avoid repeated calls to validate_world in Query::get_multiple

    @alice-i-cecile
    alice-i-cecile committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    f7aa741 View commit details
    Browse the repository at this point in the history

  4. Yeet validation 

    Co-authored-by: Boxy <supbscripter@gmail.com>
    @alice-i-cecile @BoxyUwU
    alice-i-cecile and BoxyUwU committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    141c01d View commit details
    Browse the repository at this point in the history

  5. Cargo fmt

    @alice-i-cecile
    alice-i-cecile committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    c0e5903 View commit details
    Browse the repository at this point in the history