Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove unused CountdownEvent #4290

Closed
wants to merge 2 commits into from

Conversation

MiniaczQ
Copy link
Contributor

Objective

Fixes:
#4287

Solution

I removed it.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 21, 2022
@alice-i-cecile alice-i-cecile added A-Tasks Tools for parallel and async work C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Mar 21, 2022
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Mar 21, 2022

For context, this was first added in #437. It is not used internally, and I have not seen any external users of this API.

It was previously used in our parallel executor code, but this usage was removed during the rewrite.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 21, 2022
@MiniaczQ MiniaczQ changed the title Yeet countdown event Remove unused CountdownEvent Mar 22, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 26, 2022
# Objective

Fixes:
#4287 

## Solution

I removed it.
@bors
Copy link
Contributor

bors bot commented Apr 26, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 26, 2022
# Objective

Fixes:
#4287 

## Solution

I removed it.
@bors
Copy link
Contributor

bors bot commented Apr 26, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 26, 2022
# Objective

Fixes:
#4287 

## Solution

I removed it.
@bors bors bot changed the title Remove unused CountdownEvent [Merged by Bors] - Remove unused CountdownEvent Apr 26, 2022
@bors bors bot closed this Apr 26, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
# Objective

Fixes:
bevyengine#4287 

## Solution

I removed it.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Fixes:
bevyengine#4287 

## Solution

I removed it.
@MiniaczQ MiniaczQ deleted the yeet-countdown-event branch January 14, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tasks Tools for parallel and async work C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants