Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - bevy_render: Batch insertion for prepare_uniform_components #4179

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - bevy_render: Batch insertion for prepare_uniform_components #4179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b781379
bevy_render: Batch insertion for prepare_uniform_components
superdump Mar 8, 2022
cad7c27
bevy_render: Use iterator and collect for slightly better performance
mockersf Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions crates/bevy_render/src/render_component.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,19 @@ fn prepare_uniform_components<C: Component>(
C: AsStd140 + Clone,
{
component_uniforms.uniforms.clear();
for (entity, component) in components.iter() {
commands
.get_or_spawn(entity)
.insert(DynamicUniformIndex::<C> {
index: component_uniforms.uniforms.push(component.clone()),
marker: PhantomData,
});
}
let entities = components
.iter()
.map(|(entity, component)| {
(
entity,
(DynamicUniformIndex::<C> {
index: component_uniforms.uniforms.push(component.clone()),
marker: PhantomData,
},),
)
})
.collect::<Vec<_>>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using a Local<Vec<...>> here and clearing every frame instead of allocating a new Vec.

Alternatively, insert_or_spawn_batch takes an iterator. You could pass the iterator directly into it instead of collecting into a Vec here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work. The iterator needs to be "owned" because the insertion is a deferred command. You can't "borrow" the Local vec.

commands.insert_or_spawn_batch(entities);

component_uniforms
.uniforms
Expand Down