Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add Reflect support for DMat3, DMat4, DQuat #4128

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add Reflect support for DMat3, DMat4, DQuat #4128

wants to merge 1 commit into from

Conversation

ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented Mar 7, 2022

Objective

A step towards f64 Transforms (#1680). For now, I am rolling my own Transform. But in order to derive Reflect, I specifically need DQuat to be reflectable.

#[derive(Component, Reflect, Copy, Clone, PartialEq, Debug)]
#[reflect(Component, PartialEq)]
pub struct Transform {
    pub translation: DVec3,
    pub rotation: DQuat, // error: the trait `bevy::prelude::Reflect` is not implemented for `DQuat`
    pub scale: DVec3,
}

Solution

I have added a DQuat impl for Reflect alongside the other glam impls. I've also added impls for DMat3 and DMat4 to match.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 7, 2022
@alice-i-cecile alice-i-cecile added A-Reflection Runtime information about types A-Math Fundamental domain-agnostic mathematical operations and removed S-Needs-Triage This issue needs to be labelled labels Mar 7, 2022
alice-i-cecile
alice-i-cecile approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems perfectly reasonable to me :)

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 7, 2022
@mockersf
Copy link
Member

mockersf commented Mar 8, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 8, 2022
@ItsDoot
Add Reflect support for DMat3, DMat4, DQuat (#4128)
c05ba23 
## Objective

A step towards `f64` `Transform`s (#1680). For now, I am rolling my own `Transform`. But in order to derive Reflect, I specifically need `DQuat` to be reflectable.

```rust
#[derive(Component, Reflect, Copy, Clone, PartialEq, Debug)]
#[reflect(Component, PartialEq)]
pub struct Transform {
    pub translation: DVec3,
    pub rotation: DQuat, // error: the trait `bevy::prelude::Reflect` is not implemented for `DQuat`
    pub scale: DVec3,
}
```

## Solution

I have added a `DQuat` impl for `Reflect` alongside the other glam impls. I've also added impls for `DMat3` and `DMat4` to match.
@bors
Copy link
Contributor

bors bot commented Mar 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add Reflect support for DMat3, DMat4, DQuat [Merged by Bors] - Add Reflect support for DMat3, DMat4, DQuat Mar 8, 2022
@bors bors bot closed this Mar 8, 2022
@ItsDoot ItsDoot deleted the feature/glam-reflect branch March 8, 2022 01:36
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@ItsDoot @aevyrie
Add Reflect support for DMat3, DMat4, DQuat (bevyengine#4128)
a58fc37 
## Objective

A step towards `f64` `Transform`s (bevyengine#1680). For now, I am rolling my own `Transform`. But in order to derive Reflect, I specifically need `DQuat` to be reflectable.

```rust
#[derive(Component, Reflect, Copy, Clone, PartialEq, Debug)]
#[reflect(Component, PartialEq)]
pub struct Transform {
    pub translation: DVec3,
    pub rotation: DQuat, // error: the trait `bevy::prelude::Reflect` is not implemented for `DQuat`
    pub scale: DVec3,
}
```

## Solution

I have added a `DQuat` impl for `Reflect` alongside the other glam impls. I've also added impls for `DMat3` and `DMat4` to match.
ItsDoot added a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@ItsDoot
Add Reflect support for DMat3, DMat4, DQuat (bevyengine#4128)
583bd57 
## Objective

A step towards `f64` `Transform`s (bevyengine#1680). For now, I am rolling my own `Transform`. But in order to derive Reflect, I specifically need `DQuat` to be reflectable.

```rust
#[derive(Component, Reflect, Copy, Clone, PartialEq, Debug)]
#[reflect(Component, PartialEq)]
pub struct Transform {
    pub translation: DVec3,
    pub rotation: DQuat, // error: the trait `bevy::prelude::Reflect` is not implemented for `DQuat`
    pub scale: DVec3,
}
```

## Solution

I have added a `DQuat` impl for `Reflect` alongside the other glam impls. I've also added impls for `DMat3` and `DMat4` to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Reflection Runtime information about types S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ItsDoot @mockersf @james7132 @alice-i-cecile