[Merged by Bors] - Some small changes related to run criteria piping #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the 'chaining' api, as it's peculiar Implement the label traits for Box<dyn It> (n.b., I'm not confident about this change, but it was the quickest path to not regressing) Remove the need for '`.system`' within that
DJMcNab
added
A-ECS
TheRawMeatball
approved these changes
Feb 12, 2022
alice-i-cecile
approved these changes
Feb 12, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2022
Remove the 'chaining' api, as it's peculiar ~~Implement the label traits for `Box<dyn ThatTrait>` (n.b. I'm not confident about this change, but it was the quickest path to not regressing)~~ Remove the need for '`.system`' when using run criteria piping
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
Remove the 'chaining' api, as it's peculiar ~~Implement the label traits for `Box<dyn ThatTrait>` (n.b. I'm not confident about this change, but it was the quickest path to not regressing)~~ Remove the need for '`.system`' when using run criteria piping
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
Remove the 'chaining' api, as it's peculiar ~~Implement the label traits for `Box<dyn ThatTrait>` (n.b. I'm not confident about this change, but it was the quickest path to not regressing)~~ Remove the need for '`.system`' when using run criteria piping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the 'chaining' api, as it's peculiar
Implement the label traits forBox<dyn ThatTrait>(n.b. I'm not confident about this change, but it was the quickest path to not regressing)Remove the need for '
.system' when using run criteria piping