[Merged by Bors] - Enable drag-and-drop events on windows #3772
Conversation
Veykril
changed the title
alice-i-cecile
added
A-Windowing
|
Reading through the issue thread, this fix makes a lot of sense. I'm glad that this is finally resolved. |
crates/bevy_audio/Cargo.toml
Outdated
| # we do not directly depend on cpal, but we require at least this version to be used by rodio | ||
| # so that the winit feature of drag and drop can be enabled https://github.com/RustAudio/cpal/issues/572 | ||
| cpal = ">=0.13.4" |
There was a problem hiding this comment.
I am not very happy with adding this.
Not adding it would mean that some users would have an issue until they run cargo update.
Those users would be those:
- targeting windows
- with a lock file not updated since cpal 0.13.4 has been updated (on the 21/08/06 https://crates.io/crates/cpal/0.13.4)
- with Bevy after the 0.6
I think this set of users is small enough to not add this line to the file
There was a problem hiding this comment.
Yeah, that's reasonable. Will just bumping rodio fix this?
There was a problem hiding this comment.
no, rodio merely requires cpal to be 0.13, be it the currently used one or the new version, so it will stick to the old version recorded in the cargo.lock
I figured adding this requirement for a few weeks or so would be a good idea, as that will not cause people's builds to randomly break. Kind of like a transition period for the people that use bevy from the main branch instead of the crates.io version.
There was a problem hiding this comment.
IMO we should just remove this. Breakage is much less of a concern than tech debt for this project.
james7132
added
the
P-Regression
There was a problem hiding this comment.
I can confirm this fixes #4412 , any chance we could come to an agreement that lets this PR get merged?
|
@Veykril are you free to fix this up? I'd like to move forward with this, and the remaining issue is quite minor. |
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
# Objective - Fixes #2096 ## Solution - This PR enables the drag-and-drop feature for winit on windows again, as the collision issue between cpal and winit has been fixed in RustAudio/cpal#597. I confirmed the drag and drop example working on windows 10 with this change. - ~~It also bumps the rodio version, though this is not strictly necessary.~~
bors
bot
changed the title
# Objective - Fixes bevyengine#2096 ## Solution - This PR enables the drag-and-drop feature for winit on windows again, as the collision issue between cpal and winit has been fixed in RustAudio/cpal#597. I confirmed the drag and drop example working on windows 10 with this change. - ~~It also bumps the rodio version, though this is not strictly necessary.~~
# Objective - Fixes bevyengine#2096 ## Solution - This PR enables the drag-and-drop feature for winit on windows again, as the collision issue between cpal and winit has been fixed in RustAudio/cpal#597. I confirmed the drag and drop example working on windows 10 with this change. - ~~It also bumps the rodio version, though this is not strictly necessary.~~
Objective
Solution
It also bumps the rodio version, though this is not strictly necessary.