Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix shadows for non-TriangleLists #3581

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix shadows for non-TriangleLists #3581

wants to merge 1 commit into from

Conversation

HackerFoo
Copy link
Contributor

Fixes shadows of non TriangleList meshes:

Without

Screen Shot 2022-01-07 at 13 03 02

With

Screen Shot 2022-01-07 at 13 04 06

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 7, 2022
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Jan 7, 2022
@cart
Copy link
Member

cart commented Jan 7, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jan 7, 2022
@HackerFoo
Fix shadows for non-TriangleLists (#3581)
f781bfe 
Fixes shadows of non TriangleList meshes:

# Without

<img width="1033" alt="Screen Shot 2022-01-07 at 13 03 02" src="https://user-images.githubusercontent.com/1069462/148607402-9bc47978-0b5b-45cd-a6e6-f488825cdf14.png">

# With

<img width="987" alt="Screen Shot 2022-01-07 at 13 04 06" src="https://user-images.githubusercontent.com/1069462/148607437-7d7c1d74-627f-4a7c-bf7b-205405586c17.png">
@bors
Copy link
Contributor

bors bot commented Jan 7, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix shadows for non-TriangleLists [Merged by Bors] - Fix shadows for non-TriangleLists Jan 7, 2022
@bors bors bot closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HackerFoo @cart @alice-i-cecile