Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some examples of documentation #338

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Some examples of documentation #338

merged 2 commits into from
Aug 25, 2020

Conversation

Xavientois
Copy link
Contributor

These are some small additions to the documentation to see whether I should change how I am documenting this to better fit the project

@Xavientois
Copy link
Contributor Author

Would example code make sense to have with these?

cart
cart requested changes Aug 24, 2020
View reviewed changes
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good. Just a couple of minor nits.

crates/bevy_sprite/src/entity.rs Outdated Show resolved Hide resolved
crates/bevy_sprite/src/texture_atlas.rs Outdated Show resolved Hide resolved
crates/bevy_sprite/src/texture_atlas.rs Outdated Show resolved Hide resolved
@Xavientois Xavientois requested a review from cart August 25, 2020 00:48
@cart
Copy link
Member

cart commented Aug 25, 2020

Thanks!

@cart cart merged commit 0ae74a4 into bevyengine:master Aug 25, 2020
@karroffel karroffel added the C-Docs An addition or correction to our documentation label Aug 25, 2020
BimDav pushed a commit to BimDav/bevy that referenced this pull request Aug 26, 2020
@Xavientois @BimDav
Some examples of documentation (bevyengine#338)
f8f3a32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xavientois @cart @karroffel