-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for ECS internals #3366
Documentation for ECS internals #3366
Conversation
@@ -116,6 +123,9 @@ pub(crate) struct ArchetypeComponentInfo { | |||
pub(crate) archetype_component_id: ArchetypeComponentId, | |||
} | |||
|
|||
/// A unique set of components stored within the [`World`](crate::world::World) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With sparse set components, these can contain many sets of component, although each set is uniquely assigned to a single archetype.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this! I was planning to look over this code at some point and this will be helpful
Better consistency with the rest of bevy_ecs's API.
Probably out of scope for this PR
I propose documenting sections of bevy_ecs in multiple prs instead of all at once to make reviewing + merging easier. I won't block on that, but it has my preference. |
Sounds good @cart. I'm probably going to work in this PR, then close it out and cherrypick the commits into a dozen mini-PRs. |
Alright, I think that's about all of it for a first pass. I'm going to set this down for a couple of days, and then come back to split the PRs and close this out when it's done. Most of these docs could do with being expanded with context and examples, but that will be better handled in small PRs that experts can quickly review. |
Objective
Solution
Status
This is a draft PR, so y'all can complain about my explanations as I work.
Unless there are strong objections, I'd like to tackle most of the crate in one pass, so then I can ensure that things aren't missed and the concepts are explained coherently.