Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - enable alpha mode for textures materials that are transparent #3202

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - enable alpha mode for textures materials that are transparent #3202

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

  • Transparent materials used in 3d are not transparent by default

Solution

  • Enable transparency in example

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Nov 27, 2021
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 27, 2021
@mockersf mockersf mentioned this pull request Nov 27, 2021
Closed
@mockersf mockersf removed the S-Needs-Triage This issue needs to be labelled label Nov 27, 2021
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Bug An unexpected or incorrect behavior labels Nov 27, 2021
@cart
Copy link
Member

cart commented Nov 29, 2021

bors r+

@cart cart added this to the Bevy 0.6 milestone Nov 29, 2021
bors bot pushed a commit that referenced this pull request Nov 29, 2021
@mockersf
enable alpha mode for textures materials that are transparent (#3202)
b439930 
# Objective

- Transparent materials used in 3d are not transparent by default

## Solution

- Enable transparency in example
@bors
Copy link
Contributor

bors bot commented Nov 29, 2021

Build failed:

@cart
Copy link
Member

cart commented Nov 29, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 29, 2021
@mockersf
enable alpha mode for textures materials that are transparent (#3202)
49b9f2d 
# Objective

- Transparent materials used in 3d are not transparent by default

## Solution

- Enable transparency in example
@cart
Copy link
Member

cart commented Nov 29, 2021

#3223

@bors
Copy link
Contributor

bors bot commented Nov 29, 2021

Build failed:

@cart
Copy link
Member

cart commented Nov 29, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 29, 2021
@mockersf
enable alpha mode for textures materials that are transparent (#3202)
eb15f81 
# Objective

- Transparent materials used in 3d are not transparent by default

## Solution

- Enable transparency in example
@bors
Copy link
Contributor

bors bot commented Nov 29, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title enable alpha mode for textures materials that are transparent [Merged by Bors] - enable alpha mode for textures materials that are transparent Nov 29, 2021
@bors bors bot closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@jakobhellermann jakobhellermann jakobhellermann approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@mockersf @cart @superdump @alice-i-cecile @jakobhellermann