-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add Query::contains #3090
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ac764bc
Create Query::contains
Gingeh 63feae8
Add proper docs to Query::contains
Gingeh 71796e9
Add proper docs to Query::contains
Gingeh c6e4094
Merge branch 'query_contains' of https://github.com/Gingeh/bevy into …
Gingeh 9ba8cf0
Change Query::contains to use query::get
Gingeh ddd545b
Use a better example
Gingeh 17e9fe4
my ide keeps changing this line
Gingeh 94da17c
Missed a semicolon
Gingeh 6afff3f
Merge branch 'bevyengine:main' into query_contains
Gingeh 62d066a
Use NopFetch instead
Gingeh 30a04c5
Add safety comment
Gingeh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't propose that you take any action on this comment, just noting down my thoughts.
By a strict reading of these docs, a valid implementation of this function would be
{true}
; we don't specify the behaviour if the condition is false. It is however intended to be read asif and only if
.However, this fits the pattern of documentation in
std
, e.g.Vec::contains
. I tried to find a rust-lang/rust issue on these doc items, but failed to do so.