[Merged by Bors] - bevy_render: Support removal of nodes, edges, subgraphs #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodentry
added
A-Rendering
dataphract
reviewed
Nov 11, 2021
inodentry
approved these changes
Dec 11, 2021
superdump
force-pushed
the
render-graph-rewiring
branch
from
e17dd42
to
f050ee3
Compare
superdump
changed the title
|
This is now updated on top of |
|
Also, when I changed the PR base, it looks like CI broke? |
superdump
force-pushed
the
render-graph-rewiring
branch
from
f050ee3
to
66ca428
Compare
|
bors try |
jakobhellermann
approved these changes
Mar 20, 2022
inodentry
approved these changes
Mar 20, 2022
superdump
force-pushed
the
render-graph-rewiring
branch
from
66ca428
to
7933c05
Compare
inodentry
added
the
S-Ready-For-Final-Review
cart
reviewed
Mar 21, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
Add support for removing nodes, edges, and subgraphs. This enables live re-wiring of the render graph. This was something I did to support the MSAA implementation, but it turned out to be unnecessary there. However, it is still useful so here it is in its own PR. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
) Add support for removing nodes, edges, and subgraphs. This enables live re-wiring of the render graph. This was something I did to support the MSAA implementation, but it turned out to be unnecessary there. However, it is still useful so here it is in its own PR. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
) Add support for removing nodes, edges, and subgraphs. This enables live re-wiring of the render graph. This was something I did to support the MSAA implementation, but it turned out to be unnecessary there. However, it is still useful so here it is in its own PR. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for removing nodes, edges, and subgraphs. This enables live re-wiring of the render graph.
This was something I did to support the MSAA implementation, but it turned out to be unnecessary there. However, it is still useful so here it is in its own PR.