[Merged by Bors] - Not me ... us #2654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that the new recommendation is just not to have an authors field at all, for various reasons (primarily deadnaming concerns, I think) Afaik it's no longer added by default by |
|
Ooh I dig it. Less boilerplate is good. |
alice-i-cecile
approved these changes
Aug 14, 2021
DJMcNab
approved these changes
Aug 14, 2021
| @@ -258,9 +258,8 @@ To locally lint your files using the same workflow as our CI: | |||
|
|
|||
| If you end up adding a new official Bevy crate to the `bevy` repo: | |||
|
|
|||
There was a problem hiding this comment.
We still need to make sure the other metadata is correct - at github.com/bevyengine/bevy as the url, etc.
(For example, benches doesn't have that which is probably fine)
There was a problem hiding this comment.
Thats fair, but also a bit tangential. Feel free to create a new PR / issue 😄
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 15, 2021
I don't see much of a reason at this point to boost my name over anyone elses. We are all Bevy Contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see much of a reason at this point to boost my name over anyone elses. We are all Bevy Contributors.