Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Updated remaining system panic messages to include the system name #1986

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Updated remaining system panic messages to include the system name #1986

wants to merge 1 commit into from

Conversation

TehPers
Copy link
Contributor

@TehPers TehPers commented Apr 23, 2021

Some panic messages for systems include the system name, but there's a few panic messages which do not. This PR adds the system name for the remaining panic messages.

This is a continuation of the work done in #1864.
Related: #1846

@alice-i-cecile
Copy link
Member

Ah, #1864 was what I was thinking of! This looks great, thanks for the PR.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Apr 23, 2021
@cart
Copy link
Member

cart commented Apr 23, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 23, 2021
@TehPers
Updated remaining system panic messages to include the system name (#…
0a587ac 
…1986)

Some panic messages for systems include the system name, but there's a few panic messages which do not. This PR adds the system name for the remaining panic messages.

This is a continuation of the work done in #1864.
Related: #1846
@bors
Copy link
Contributor

bors bot commented Apr 23, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Updated remaining system panic messages to include the system name [Merged by Bors] - Updated remaining system panic messages to include the system name Apr 23, 2021
@bors bors bot closed this Apr 23, 2021
@TehPers TehPers deleted the better_system_panic_messages branch April 23, 2021 23:12
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@TehPers @ostwilkens
Updated remaining system panic messages to include the system name (b…
d78fa76 
…evyengine#1986)

Some panic messages for systems include the system name, but there's a few panic messages which do not. This PR adds the system name for the remaining panic messages.

This is a continuation of the work done in bevyengine#1864.
Related: bevyengine#1846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TehPers @alice-i-cecile @cart @mockersf