[Merged by Bors] - add documentation on LogPlugin and more log usage #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
ghost
reviewed
Apr 21, 2021
ghost
reviewed
Apr 21, 2021
ghost
reviewed
Apr 21, 2021
| } else { | ||
| println!("sphere hasn't loaded yet"); | ||
| info!("sphere hasn't loaded yet"); |
There was a problem hiding this comment.
This is nitpicking but there is some inconsistency in examples now whether capitalization is used at the start for the log messages.
E.g.
"sphere hasn't loaded yet"
vs.
""Custom asset loaded: {:?}"
in custom_asset.rs
There was a problem hiding this comment.
I think starting with a capital is the right call. Feel free to follow up with another pr that makes this consistent if you feel inclined :)
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
Fixes #1895 Changed most `println` to `info` in examples, some to `warn` when it was useful to differentiate from other more noisy logs. Added doc on `LogPlugin`, how to configure it, and why (and how) you may need to disable it
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
Fixes bevyengine#1895 Changed most `println` to `info` in examples, some to `warn` when it was useful to differentiate from other more noisy logs. Added doc on `LogPlugin`, how to configure it, and why (and how) you may need to disable it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1895
Changed most
printlntoinfoin examples, some towarnwhen it was useful to differentiate from other more noisy logs.Added doc on
LogPlugin, how to configure it, and why (and how) you may need to disable it