[Merged by Bors] - Added example of entity sorting by components #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since there were large changes and the original code doesn't exist anymore, where should I put the example? |
alice-i-cecile
added
C-Docs
|
I would include this example as part of docs on |
|
I think including a complicated sort in the query iter doc comments is a bit distracting. It forces users to mentally break down what the sort is doing, which feels pretty tangential to the goal of teaching them how to query for something. Imo using |
|
Or alternatively simplify the sort by only sorting a single item, not using reverse, and using |
YohDeadfall
force-pushed
the
sort-example
branch
from
ea45962
to
3b8f10a
Compare
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
YohDeadfall
force-pushed
the
sort-example
branch
from
06ae11e
to
4a9d89b
Compare
alice-i-cecile
approved these changes
Apr 17, 2021
mockersf
reviewed
Apr 17, 2021
mockersf
reviewed
Apr 17, 2021
mockersf
reviewed
Apr 17, 2021
mockersf
reviewed
Apr 17, 2021
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2021
We discussed with @alice-i-cecile privately on iterators and agreed that making a custom ordered iterator over query makes no sense since materialization is required anyway and it's better to reuse existing components or code. Therefore, just adding an example to the documentation as requested. Fixes #1470. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
We discussed with @alice-i-cecile privately on iterators and agreed that making a custom ordered iterator over query makes no sense since materialization is required anyway and it's better to reuse existing components or code. Therefore, just adding an example to the documentation as requested. Fixes bevyengine#1470. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed with @alice-i-cecile privately on iterators and agreed that making a custom ordered iterator over query makes no sense since materialization is required anyway and it's better to reuse existing components or code. Therefore, just adding an example to the documentation as requested.
Fixes #1470.