[Merged by Bors] - gltf: load textures asynchronously using io task pool #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Assets
|
not sure how to make that works on wasm... |
mockersf
force-pushed
the
gltf-async-textures
branch
from
27552c2
to
f3c2724
Compare
|
I sidestepped the wasm multithread issue (aka no multithread in wasm) by ... staying single threaded in wasm and choosing which to execute with a |
|
I don't know if it's of any help, but did you already read this? |
single threaded behavior for wasm
mockersf
force-pushed
the
gltf-async-textures
branch
from
ef397e5
to
66b4849
Compare
|
on my laptop, loading With this PR, 2.7 seconds: We can see that two threads are doing the work. |
|
why this can't work in wasm and need the workaround of not using the task pool: #1924 |
|
Cool this seems like the right approach for now. I added a quick TODO to remind us to unify impls when we can. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 30, 2021
While trying to reduce load time of gltf files, I noticed most of the loading time is spent transforming bytes into an actual texture. This PR add asynchronously loading for them using io task pool in gltf loader. It reduces loading of a large glb file from 15 seconds to 6~8 on my laptop To allow asynchronous tasks in an asset loader, I added a reference to the task pool from the asset server in the load context, which I can use later in the loader. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
While trying to reduce load time of gltf files, I noticed most of the loading time is spent transforming bytes into an actual texture. This PR add asynchronously loading for them using io task pool in gltf loader. It reduces loading of a large glb file from 15 seconds to 6~8 on my laptop To allow asynchronous tasks in an asset loader, I added a reference to the task pool from the asset server in the load context, which I can use later in the loader. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
vabrador
pushed a commit
to vabrador/bevy
that referenced
this pull request
Sep 15, 2021
While trying to reduce load time of gltf files, I noticed most of the loading time is spent transforming bytes into an actual texture. This PR add asynchronously loading for them using io task pool in gltf loader. It reduces loading of a large glb file from 15 seconds to 6~8 on my laptop To allow asynchronous tasks in an asset loader, I added a reference to the task pool from the asset server in the load context, which I can use later in the loader. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to reduce load time of gltf files, I noticed most of the loading time is spent transforming bytes into an actual texture.
This PR add asynchronously loading for them using io task pool in gltf loader. It reduces loading of a large glb file from 15 seconds to 6~8 on my laptop
To allow asynchronous tasks in an asset loader, I added a reference to the task pool from the asset server in the load context, which I can use later in the loader.