Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix beta CI #16984

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Fix beta CI #16984

merged 2 commits into from
Dec 26, 2024

Conversation

BenjaminBrienen
Copy link
Contributor

Objective

Fixes #16607

Solution

Satisfy clippy

Testing

Ran clippy

@BenjaminBrienen BenjaminBrienen self-assigned this Dec 26, 2024
@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Cross-Cutting Impacts the entire engine S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 26, 2024
alice-i-cecile
alice-i-cecile approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer, I like this lint!

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 26, 2024
Merged via the queue into bevyengine:main with commit 1675d68 Dec 26, 2024
34 checks passed
@BenjaminBrienen BenjaminBrienen deleted the fix-beta branch December 28, 2024 20:44
@BenjaminBrienen BenjaminBrienen removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 28, 2024
@BenjaminBrienen BenjaminBrienen mentioned this pull request Dec 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 29, 2024
@BenjaminBrienen
Fix random clippy warning (#17010)
847c3a1 
# Objective

Follow-up to #16984 

## Solution

Fix the lint

## Testing

```
PS C:\Users\BenjaminBrienen\source\bevy> cargo clippy
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.71s
PS C:\Users\BenjaminBrienen\source\bevy> cargo clippy -p bevy_ecs
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.21s
```
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@BenjaminBrienen @ecoskey
Fix beta CI (bevyengine#16984)
bde89c1 
# Objective

Fixes bevyengine#16607

## Solution

Satisfy clippy

## Testing

Ran clippy
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@BenjaminBrienen @ecoskey
Fix random clippy warning (bevyengine#17010)
a8f6a65 
# Objective

Follow-up to bevyengine#16984 

## Solution

Fix the lint

## Testing

```
PS C:\Users\BenjaminBrienen\source\bevy> cargo clippy
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.71s
PS C:\Users\BenjaminBrienen\source\bevy> cargo clippy -p bevy_ecs
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.21s
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Main branch fails to compile on Rust beta.
2 participants
@BenjaminBrienen @alice-i-cecile