Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in bevy_picking module docs #16265

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix typos in bevy_picking module docs #16265

merged 2 commits into from
Nov 8, 2024

Conversation

doup
Copy link
Contributor

@doup doup commented Nov 6, 2024

Objective

  • Fix typo: ovserver => observer

@doup
Fix typo in bevy_picking module docs
d78e7c8 
`ovserver` => `observer`
@Vrixyz
Copy link
Member

Vrixyz commented Nov 6, 2024 •
edited
Loading

I noticed a few more, I'll list them here just so there's a trace:

  • haulted -> halted
  • abstracton -> abstraction
  • "whether its the included mouse" -> "whether it's the included mouse"

It might be interesting to consider a PR to typos ci project.

@Vrixyz Vrixyz added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-Picking Pointing at and selecting objects of all sorts labels Nov 6, 2024
@Vrixyz Vrixyz added this to the 0.15 milestone Nov 6, 2024
@doup @Vrixyz
Fix typos in bevy_picking module
75ac12d 
Co-Authored-By: Thierry Berger <contact@thierryberger.com>
@doup doup changed the title Fix typo in bevy_picking module docs Fix typos in bevy_picking module docs Nov 6, 2024
@BenjaminBrienen
Copy link
Contributor

I am working on a follow-up to this that addresses more typos and missing commas across all files.

@doup
Copy link
Contributor Author

doup commented Nov 6, 2024

Cool. I've proposed two typos for the November batch of crate-ci/typos.

@mweatherley mweatherley added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 7, 2024
@cart cart added this pull request to the merge queue Nov 8, 2024
Merged via the queue into bevyengine:main with commit 2b43403 Nov 8, 2024
30 checks passed
@doup doup deleted the patch-1 branch November 8, 2024 08:30
mockersf pushed a commit that referenced this pull request Nov 11, 2024
@doup @Vrixyz @mockersf
Fix typos in bevy_picking module docs (#16265)
758ae48 
# Objective

- Fix typo: `ovserver` => `observer`

---------

Co-authored-by: Thierry Berger <contact@thierryberger.com>
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Dec 2, 2024
@doup @Vrixyz @ecoskey
Fix typos in bevy_picking module docs (bevyengine#16265)
77b0575 
# Objective

- Fix typo: `ovserver` => `observer`

---------

Co-authored-by: Thierry Berger <contact@thierryberger.com>
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@doup @Vrixyz @ecoskey
Fix typos in bevy_picking module docs (bevyengine#16265)
d455a24 
# Objective

- Fix typo: `ovserver` => `observer`

---------

Co-authored-by: Thierry Berger <contact@thierryberger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-Picking Pointing at and selecting objects of all sorts C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
5 participants
@doup @Vrixyz @BenjaminBrienen @cart @mweatherley