Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OIT shaders error with DX12 backend #15782

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix OIT shaders error with DX12 backend #15782

merged 2 commits into from
Oct 10, 2024

Conversation

akimakinai
Copy link
Contributor

@akimakinai akimakinai commented Oct 9, 2024 •
edited
Loading

Objective

Solution

Upstream issue: gfx-rs/wgpu#4458 gpuweb/gpuweb#2523

Testing

  • Tested order_independent_transparency example with both dx12 and vulkan backend on Windows

@tim-blackbird tim-blackbird added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 9, 2024
@alice-i-cecile alice-i-cecile added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Oct 9, 2024
IceSentry
IceSentry approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really unfortunate, it makes the code way uglier than it has to be. But I guess this is unavoidable for now. Thanks for finding this.

tychedelia
tychedelia approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is good to remember when we review in the future.

@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 9, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 9, 2024
@alice-i-cecile
Copy link
Member

@akimakinai I'm going to leave this up for a few days; let me know if you won't have time / interest in implementing @IceSentry's small suggestion. I'm content to merge this without that change, but it would be a nice improvement.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 10, 2024
Merged via the queue into bevyengine:main with commit 11d1ebe Oct 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

OIT shader crashes with DX12 backend
5 participants
@akimakinai @alice-i-cecile @IceSentry @tychedelia @tim-blackbird