Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing renaming of Input -> ButtonInput #12096

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Fix missing renaming of Input -> ButtonInput #12096

merged 2 commits into from
Feb 24, 2024

Conversation

ShadowMitia
Copy link
Contributor

@ShadowMitia ShadowMitia commented Feb 24, 2024 •
edited
Loading

Objective

  • Fix a wrongly named type

Solution

  • Rename it properly

@nicopap nicopap added C-Docs An addition or correction to our documentation A-Input Player input via keyboard, mouse, gamepad, and more labels Feb 24, 2024
@alice-i-cecile @nicopap
Use a direct doc link
ce9933e 
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 24, 2024
@alice-i-cecile
Copy link
Member

Thanks!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 24, 2024
Merged via the queue into bevyengine:main with commit 65267dd Feb 24, 2024
24 checks passed
@ShadowMitia ShadowMitia deleted the patch-1 branch February 24, 2024 21:21
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@ShadowMitia @alice-i-cecile
@nicopap @msvbg
Fix missing renaming of Input -> ButtonInput (bevyengine#12096)
1de986f 
# Objective

- Fix a wrongly named type

## Solution

- Rename it properly

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@ShadowMitia @alice-i-cecile
@nicopap @msvbg
Fix missing renaming of Input -> ButtonInput (bevyengine#12096)
c30b42c 
# Objective

- Fix a wrongly named type

## Solution

- Rename it properly

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopap nicopap nicopap left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShadowMitia @alice-i-cecile @nicopap