Subpixel text positioning #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with the decisions made here. Its nice to have the option if/when people care, but it will likely significantly affect gpu memory usage (and atlas rebinds). |
rparrett
pushed a commit
to rparrett/bevy
that referenced
this pull request
Jan 27, 2021
* cleanup unnecessary changes from PR bevyengine#1171 * add feature to correctly render glyphs with sub-pixel positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature to support sub-pixel glyph positioning. This requires creating multiple atlas sprites per glyph based on the sub-pixel offset of the glyph in its layout. As this will increase the amount of texture memory required I placed it behind a feature gate which is not enabled by default.
In the example below you can see several differences in the rendering of glyphs, in particular the final 'e' is different from the first one, and the spacing of the adjacent 'l' is better.
By getting the placement correct, the glyphs in the right justified text in the text_debug example no longer jiggle.
wo-subpixel.mp4
w-subpixel.mp4