Use the scroll wheel to control the camera speed in examples #11921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kanabenki
added
C-Examples
Kanabenki
force-pushed
the
example-camera-scroll-speed
branch
from
3afe987 to
4df5ac3
Compare
alice-i-cecile
approved these changes
Feb 18, 2024
|
@DGriffin91 your review here would work well too :) |
DGriffin91
approved these changes
Feb 18, 2024
I'm interested if someone has an input device that uses pixel scroll since I don't, to check that the pixel to line ratio I picked seems reasonable. |
alice-i-cecile
added
the
S-Ready-For-Final-Review
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…ine#11921) # Objective - Closes bevyengine#9384. ## Solution - Make the movement speed of the `CameraController` adjustable with the scroll wheel as mentioned [here](bevyengine#9384 (comment)). The speed use an exponential progression (10% increase per scroll tick by default) to allow adapting the speed to different scales. - For the `scene_viewer` example, make the default speed proportional to the size of the scene using what's computed for the default camera placement. This gives a good enough default to fly over the scene from the outside. I don't think there's a good way to get a default speed fitting for all scenes since some are meant to be viewed from outside while other are traversable environments.
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…ine#11921) # Objective - Closes bevyengine#9384. ## Solution - Make the movement speed of the `CameraController` adjustable with the scroll wheel as mentioned [here](bevyengine#9384 (comment)). The speed use an exponential progression (10% increase per scroll tick by default) to allow adapting the speed to different scales. - For the `scene_viewer` example, make the default speed proportional to the size of the scene using what's computed for the default camera placement. This gives a good enough default to fly over the scene from the outside. I don't think there's a good way to get a default speed fitting for all scenes since some are meant to be viewed from outside while other are traversable environments.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
scene_viewermovement speed proportional to scene size #9384.Solution
CameraControlleradjustable with the scroll wheel as mentioned here. The speed use an exponential progression (10% increase per scroll tick by default) to allow adapting the speed to different scales.scene_viewerexample, make the default speed proportional to the size of the scene using what's computed for the default camera placement. This gives a good enough default to fly over the scene from the outside. I don't think there's a good way to get a default speed fitting for all scenes since some are meant to be viewed from outside while other are traversable environments.