Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri is failing on latest nightly: pin nightly to last known working version #11421

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Pin nightly to before it was merged

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Jan 19, 2024
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 19, 2024
@mockersf mockersf added this pull request to the merge queue Jan 19, 2024
Merged via the queue into bevyengine:main with commit cd2cdb4 Jan 19, 2024
25 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2024
# Objective

- Using the latest nightly for `miri` is generally desirable as we want
to catch regressions upstream or new problems quickly
- rust-lang/rust#120123 should be merged now, so
it should work.

## Solution

- Revert #11421.

---------

Co-authored-by: François <mockersf@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants