Exposure settings (adopted) #11347
Merged
Exposure settings (adopted) #11347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExposureSettings rebase + improvements
Closed
Co-authored-by: vero <email@atlasdostal.com>
fintelia
reviewed
Jan 15, 2024
alice-i-cecile
added
P-High
Co-authored-by: vero <email@atlasdostal.com>
atlv24
reviewed
Jan 15, 2024
atlv24
approved these changes
Jan 15, 2024
Co-authored-by: vero <email@atlasdostal.com>
JMS55
added
the
S-Ready-For-Final-Review
atlv24
approved these changes
Jan 16, 2024
Fix lightmaps example
more fixing ...
fintelia
reviewed
Jan 16, 2024
| @@ -8,7 +8,7 @@ fn main() { | |||
| .add_plugins(DefaultPlugins) | |||
| .insert_resource(AmbientLight { | |||
| color: Color::WHITE, | |||
| brightness: 0.2, | |||
| brightness: 0.0, | |||
There was a problem hiding this comment.
Is there a (non-zero) default value for the ambient light? Because it doesn't seem like inserting a light with brightness set to zero should actually do much of anything
There was a problem hiding this comment.
Yes, the default is 0.005 or something. If you don't want any ambient light (using lightmaps or IBL instead), then you need to override it to be 0 like this.
There was a problem hiding this comment.
Yes it has a non-zero default. https://github.com/bevyengine/bevy/blob/main/crates/bevy_pbr/src/light.rs#L550
alice-i-cecile
approved these changes
Jan 16, 2024
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
…11389) # Objective Fixes #11376 During the development of the exposure settings PR (#11347) all examples with lighting had to be adjusted, but three were missed or simply didn't exist yet at the time. This PR restores the brightness in those examples again: render_ui_to_texture asset_loading hot_asset_reloading All of them are a bit brighter now compared to before the exposure PR, but it looks better IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and finished version of #8407. Huge thanks to @GitGhillie for adjusting all the examples, and the many other people who helped write this PR (@superdump , @coreh , among others) :)
Fixes #8369
Changelog
brightnesscontrol toSkybox.intensitycontrol toEnvironmentMapLight.ExposureSettingsandPhysicalCameraParametersfor controlling exposure of 3D cameras.DirectionalLightexposure Bevy previously hardcoded internally.Migration Guide
SkyboxorEnvironmentMapLight, use the newbrightnessandintensitycontrols to adjust their strength.ExposureSettingscomponent to compensate.