Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced TableRow as Casting #10811

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Reduced TableRow as Casting #10811

merged 7 commits into from
Dec 5, 2023

Commits on Nov 30, 2023

  1. Replaced TableRow new and index with from_* and as_* 

    Localizes all instances of `as` casting into a pair of properly checked functions with `debug_assertions`. By using `debug_assertions` any runtime costs are avoided.
    @bushrat011899
    bushrat011899 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    58e5dcd View commit details
    Browse the repository at this point in the history

  2. Updated TableRow from_* and as_* assertions 

    Using forward-reverse casting to ensure value is invariant.
    @bushrat011899
    bushrat011899 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    3acff73 View commit details
    Browse the repository at this point in the history

  3. Updated TableRow from_* assertions to assert 

    Also removed `as_*` assertion since `usize` is guaranteed to be `u32` or larger in Bevy.
    @bushrat011899
    bushrat011899 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    5a9b2c8 View commit details
    Browse the repository at this point in the history

  4. Updated TableRow from_* assertions to assert 

    Also removed `as_*` assertion since `usize` is guaranteed to be `u32` or larger in Bevy.
    @bushrat011899
    bushrat011899 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    147bb13 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'TableU32Operations' of https://github.com/bushrat011899… 

    …/bevy into TableU32Operations
    @bushrat011899
    bushrat011899 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    b8d7f5d View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Merge remote-tracking branch 'upstream/main' into TableU32Operations

    @bushrat011899
    bushrat011899 committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    6da634b View commit details
    Browse the repository at this point in the history

  2. Resolve upstream conflicts 

    Added `assert` in `QueryIter::fold_over_table_range` out of the loop to hint compiler on optimisation.
    @bushrat011899
    bushrat011899 committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    f8612ca View commit details
    Browse the repository at this point in the history